[Libssh] latest SVN version breaks sshv1

[Norbert Kiesel]

Actually spoke too early: I re-tested w/i running "make install"....

434 fails ssh1 due to a typo in the kex.c code cleanup: it always
returns -1.  See attached trivial patch kex_434.diff that makes sshv1
work for me again.

</nk>


On Wed, 2009-04-08 at 09:03 -0700, Norbert Kiesel wrote:
> I just upgraded to rev#434. This has a typo resulting in a compile error
> in channels1.c (stray ;), and some more warnings about const/non-const
> mismatches.  See attached patch v1_434.diff.  Good news is that is seems
> to still work with sshv1 (only light testing so far though).
> 
> </nk>
> 
> 
> On Wed, 2009-04-08 at 09:24 +0200, Andreas Schneider wrote:
> > On Wednesday 08 April 2009 09:14:47 Aris Adamantiadis wrote:
> > > Norbert Kiesel a écrit :
> > > > First, sshv1 did not compile.  I fixed this (see below for patch
> > > > v1.diff), and also moved the ssh_option_free in ssh_cleanup further down
> > > > (so that the log_function in options stays valid) which fixes as segv
> > > > with debug level 9.
> > 
> > Thanks you very much for the patches Norbert.
> > 
> > > Thanks for your precious feedback. I'll verify if the Windowing works
> > > the same way under SSH1 and SSH2. Behind near a release, we can't miss
> > > important things like this.
> > 
> > Aris: I've commited the patches and set window to 64000 and the maxpacket to 
> > 32000 like in SSHv2. Please test!
> > 
> > I haven't started to fix SSHv1 functions yet.
> > 
> > It would be great if we could switch to git, so people who send patches are 
> > really shown as the patch provider in the logs.
> > 
> > >
> > > Regards,
> > >
> > > Aris
> > >
> > 
> > 	-- andreas
> > _______________________________________________
> > Libssh mailing list
> > Libssh at cerkinfo.be
> > http://www.cerkinfo.be/cgi-bin/mailman/listinfo/libssh
> _______________________________________________
> Libssh mailing list
> Libssh at cerkinfo.be
> http://www.cerkinfo.be/cgi-bin/mailman/listinfo/libssh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kex_434.diff
Type: text/x-patch
Size: 230 bytes
Desc: not available
Url : http://www.cerkinfo.be/pipermail/libssh/attachments/20090408/dfa9a76d/attachment.bin