[Libssh] latest SVN version breaks sshv1

[Norbert Kiesel]

Hi,

just updated my sandbox with version 423 and this breaks sshv1.  I
_think_ I had something like version 377 or so (not 100% sure, any way
to find out?) and that works (I still have th2 so.2 library and my test
program linked against that works).

First, sshv1 did not compile.  I fixed this (see below for patch
v1.diff), and also moved the ssh_option_free in ssh_cleanup further down
(so that the log_function in options stays valid) which fixes as segv
with debug level 9.

By comparing the logs (attached failure_log and working_log), I traced
the difference down to a call to grow_window in channels.c (added in
rev#415).  Seems sshv1 can't deal with that.  It enters that function
because local_window was never initialized for sshv1.  I made it work by
setting chan->local_window to WINDOWSIZE (see below for patch
channels1.diff). Is this the right fix?

</nk>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1.diff
Type: text/x-patch
Size: 4531 bytes
Desc: not available
Url : http://www.cerkinfo.be/pipermail/libssh/attachments/20090407/25549aa8/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: channels1.diff
Type: text/x-patch
Size: 1051 bytes
Desc: not available
Url : http://www.cerkinfo.be/pipermail/libssh/attachments/20090407/25549aa8/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: failure_log.gz
Type: application/x-gzip
Size: 2289 bytes
Desc: not available
Url : http://www.cerkinfo.be/pipermail/libssh/attachments/20090407/25549aa8/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: working_log.gz
Type: application/x-gzip
Size: 913 bytes
Desc: not available
Url : http://www.cerkinfo.be/pipermail/libssh/attachments/20090407/25549aa8/attachment-0003.bin